Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changes to avoid sending logs to logdna #1051

Merged
merged 2 commits into from
Oct 18, 2024
Merged

fix: changes to avoid sending logs to logdna #1051

merged 2 commits into from
Oct 18, 2024

Conversation

imprateeksh
Copy link
Member

Description

This is regarding the issue where we have to discontinue the usage of LogDNA and use IBM Cloud Logs. While the other solution is in progress but this change is to stop sending logs to logdna.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@imprateeksh imprateeksh self-assigned this Oct 18, 2024
@imprateeksh imprateeksh requested a review from ocofaigh as a code owner October 18, 2024 13:08
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@imprateeksh
Copy link
Member Author

Removed ICL reference and also removed some unused variables.

image

@ocofaigh ocofaigh merged commit 7a3c750 into main Oct 18, 2024
1 check passed
@ocofaigh ocofaigh deleted the remove-logdna branch October 18, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants